Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdc): Revert "fix(direct cdc): use time.precision.mode=connect (#16119)" #16842

Merged
merged 1 commit into from
May 21, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented May 20, 2024

This reverts commit 5fb6f69.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

PR #16119 will truncate PG timestamp precision from microseconds to milliseconds, which is unexpected. We should not truncate the value if RW data type can fully store the upstream value.

A better solution is suggested in #16097 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@StrikeW StrikeW requested review from fuyufjh and xiangjinwu May 20, 2024 15:15
@github-actions github-actions bot added the type/fix Bug fix label May 20, 2024
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's create an issue for the follow-ups #16852

@StrikeW StrikeW added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 96e2002 May 21, 2024
31 of 33 checks passed
@StrikeW StrikeW deleted the siyuan/fix-time-precision branch May 21, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants